Joe Dinsdale

Results 16 comments of Joe Dinsdale

@HarshilJ Sorry for the late reply! This sounds more like a one-off use case and not something that is a common reusable pattern. (see [Contribution guide](https://github.com/sky-uk/toolkit/blob/develop/CONTRIBUTING.md#requirements) This is something that...

Digging a little deeper, this only seems to be caused by ``. Non buttons seem to render correctly.

Currently the only fix I've found without breaking changes is to use `` rather than the `` for the `c-card` element. Not the most semantic but struggling to find an...

This appears to have been fixed in the latest Firefox release: ![screen shot 2018-02-26 at 15 09 34](https://user-images.githubusercontent.com/2472440/36677833-1cc8d7dc-1b07-11e8-85d9-9ce888ab51a9.png) Will leave ticket open to keep an eye on the issue.

This issue appeared again with FireFox 63. Recommend we remove the pseudo shadows and replace with an animated `box-shadow` for an interim fix.

@steveduffin I guess an example would be vars associated with buttons such as spacing and border width which should also be aligned with forms, select and dropdowns etc. We should...

I approve, could always do a soft rollout of this with: ``` .u-padding, .u-padding-all {...} ``` That way we can introduce it and start transitioning over straight away rather than...

I think this is an improvement, the indicator animation looks much better. Personally not too keen on the content scaling but I think its subtle enough. @steveduffin yes the `max-height`...

I think Danger would be ace and is great for reducing pain for reviews by catching common issues early however I think most of the confusion happens before that point...