RunKV icon indicating copy to clipboard operation
RunKV copied to clipboard

replace unnecessary Bytes with Vec<u8> and &[u8] in storage module

Open MrCroxx opened this issue 2 years ago • 2 comments

As in #74 , create or clone Bytes involves atomic operation, whose costs cannot be ignored if performs frequently (e.g. in iterators). Unnecessary Bytes should be replaced with Vec<u8> or &[u8].

MrCroxx avatar Mar 30 '22 05:03 MrCroxx

lgtm

zackertypical avatar Apr 08 '22 13:04 zackertypical

@zackertypical Welcome, please make sure to run make fmt to lint the codw and resolve all warnings manually, otherwise CI would not pass.

MrCroxx avatar Apr 08 '22 14:04 MrCroxx