Controllable icon indicating copy to clipboard operation
Controllable copied to clipboard

Suggestions for crafting

Open SapphireBulletBill opened this issue 4 years ago • 3 comments

First of all, I would like to say: THIS UPDATE IS AMAZING.

All of the major problems I was having in v0.9.1 are gone, and we finally have D-Pad crafting! And to think this update came out literally 2 days after my complaint. I tested out Survival and Creative last night and it works so well on controller. Now I am generally satisfied with this supportive mod and would recommend it to anyone.

Minor Bugs:

  • ~~When the Virtual Mouse is disabled, the player cannot use the D-Pad for crafting nor navigating menus.~~
  • ~~When the Virtual Mouse is disabled and the player is moving the mouse while in the crafting menu, the "Close Inventory" icon flickers.~~
  • ~~The Vibration feature doesn't seem to work, despite it working in the previous version of Controllable~~
  • ~~For option menus that use a vertical scroll bar, sometimes when attempting to use the mouse, the bar is stuck to the bottom in some cases.~~

Suggestions to Improve the Crafting (If feasible):

  • Map the B button to close the crafting menu, and Y as quick move.
  • ~~Allow the player to instantly craft the item by clicking it in the Recipe Book, similar to Bedrock Edition.~~
  • Allow the player to quickly move between the Book/Inventory interfaces with LB/RB. (Bedrock Edition does this with a L-Stick press.)

Keep up the fantastic work, and take all the time you need.

SapphireBulletBill avatar Jan 29 '21 23:01 SapphireBulletBill

"When the Virtual Mouse is disabled, the player cannot use the D-Pad for crafting nor navigating menus." Fixed in https://github.com/MrCrayfish/Controllable/commit/0f5ef1c3244cff454a862868bc65f4b903bb5860

"When the Virtual Mouse is disabled and the player is moving the mouse while in the crafting menu, the "Close Inventory" icon flickers." Fixed in https://github.com/MrCrayfish/Controllable/commit/2ee0124a38b9a5d758071b19ba70b25b2eb06b1a

"The Vibration feature doesn't seem to work, despite it working in the previous version of Controllable" The mod has switched to GLFW which doesn't support rumble. However this should be changing soon. (https://github.com/glfw/glfw/pull/1678 and original issue https://github.com/glfw/glfw/pull/1678)

"For option menus that use a vertical scroll bar, sometimes when attempting to use the mouse, the bar is stuck to the bottom in some cases." Fixed in https://github.com/MrCrayfish/Controllable/commit/b649d5c97d5af594589049f0af9d7d2293c78a15

MrCrayfish avatar Feb 02 '21 10:02 MrCrayfish

glfw/glfw#1678 was added in April, so I doubt it will be merged anytime soon. Can you ship your own fork of glfw?

jadenPete avatar Feb 03 '21 20:02 jadenPete

I've added support to craft items directly from the recipe book https://github.com/MrCrayfish/Controllable/commit/f29bfceb0ae9691b2715d5abca04af7ce6d94552

MrCrayfish avatar Feb 09 '21 09:02 MrCrayfish