LiveStreamDVR icon indicating copy to clipboard operation
LiveStreamDVR copied to clipboard

Every stream recorded is marked as vod deleted from twitch when no internet is available.

Open KurtzPT opened this issue 2 years ago • 24 comments

Basically what title says, my Internet failed for two hours and in that time LiveStreamDVR started the vods checks and instead of ignoring the result (because no internet), it marked every single recordings as deleted from vod on twitch:

image

KurtzPT avatar May 13 '22 13:05 KurtzPT

got a bluescreen while re-enabling my network interface

very cursed issue

MrBrax avatar May 13 '22 14:05 MrBrax

https://github.com/axios/axios/issues/2986

i guess it's a bit more complicated than just a message check? it did return no address or something for me, but there might be multiple errors

MrBrax avatar May 13 '22 14:05 MrBrax

I'm not sure how the vod check is done but shouldn't just mark something as deleted ONLY if it gets a response from twitch but the page does not have the video? That way it doesn't matter if twitch is down or if I have an internet connectivity issue, it should not mark the vods as deleted in both of those cases.

KurtzPT avatar May 13 '22 21:05 KurtzPT

Also how can I now fix this mess? Is there any way of requesting LiveStreamDVR to check every single record for vod availability ?

KurtzPT avatar May 13 '22 21:05 KurtzPT

click the refresh button next to the vod id, i pushed an addition to have it on completely deleted ones too but can't remember if i merged it

MrBrax avatar May 13 '22 21:05 MrBrax

click the refresh button next to the vod id, i pushed an addition to have it on completely deleted ones too but can't remember if i merged it

But that's one by one, no way of doing it all? it's still a bunch of records.

KurtzPT avatar May 13 '22 21:05 KurtzPT

image

Nevermind, there's no refresh button while its marked as deleted.

KurtzPT avatar May 13 '22 21:05 KurtzPT

i think the cron should fix it, or going to /cron/check_deleted_vods

MrBrax avatar May 13 '22 21:05 MrBrax

i think the cron should fix it, or going to /cron/check_deleted_vods

https://<host>/cron/check_deleted_vods ?

Doesn't seem to do anything.

KurtzPT avatar May 13 '22 21:05 KurtzPT

right, /api/v0/cron/check_deleted_vods

MrBrax avatar May 13 '22 21:05 MrBrax

I remember having a page showing these cron, but not anymore it seems they disappeared. Anyway that worked. 👍

KurtzPT avatar May 13 '22 21:05 KurtzPT

yeah because they run internally now, if enabled in the scheduler option in settings

MrBrax avatar May 13 '22 21:05 MrBrax

yeah because they run internally now, if enabled in the scheduler option in settings

I have them enabled, maybe there's a way of having a button in the tools page to run these checks manually? (suggestion)

KurtzPT avatar May 13 '22 21:05 KurtzPT

I just noticed now last stream of Asmongold (Yesterday) is marked as VOD deleted and says "The VOD probably never got saved."

image

But that's not true, the VOD is here: https://www.twitch.tv/videos/1481888628

Possible new issue?

KurtzPT avatar May 13 '22 21:05 KurtzPT

does he have the new thing that vods are not shown by default maybe?

MrBrax avatar May 13 '22 23:05 MrBrax

does he have the new thing that vods are not shown by default maybe?

Not sure what is that, I found the vod by just checking last broadcasts on his page.

KurtzPT avatar May 14 '22 00:05 KurtzPT

1652556152404

so he's streaming right now but the vod isn't visible. not really anything i can do other than add a "match vod" cronjob i guess, for when the channel makes the vod public?

MrBrax avatar May 14 '22 19:05 MrBrax

I didn't know hiding vods while streaming was a thing. I guess the match vod cronjob would be a nice thing to have then.

KurtzPT avatar May 16 '22 12:05 KurtzPT

How frequently is this cron running? Trying to figure out if it's working because I have a streamer that all vods are marked as deleted when it shouldn't have.

KurtzPT avatar May 27 '22 11:05 KurtzPT

How frequently is this cron running? Trying to figure out if it's working because I have a streamer that all vods are marked as deleted when it shouldn't have.

it should be running twice a day and output to the log, however if the vod has an id it won't check

MrBrax avatar May 27 '22 16:05 MrBrax

Seems to be working the cron.

KurtzPT avatar May 30 '22 16:05 KurtzPT

@MrBrax not sure if this is related but I'm starting to see the following on some recordings:

image

That red exclamation mark, never seen that before. What is it and how can I fix it (if there's something to fix?)

KurtzPT avatar May 31 '22 13:05 KurtzPT

i should have fixed it, i had accidentally made the issue fixer put that on there before it even started recording

the error is for when the stream is sub only or something else happened, so it doesn't go on as red flashing capturing forever

MrBrax avatar May 31 '22 14:05 MrBrax

Interesting, after updating to the latest build image these warnings disappeared. So I guess this was the first case you are mentioning and I just didn't had the update with the fix yet.

KurtzPT avatar May 31 '22 14:05 KurtzPT