django-vite icon indicating copy to clipboard operation
django-vite copied to clipboard

Allow using staticfile finders for manifest path

Open akx opened this issue 8 months ago • 2 comments

This PR makes it possible to specify manifest_path as a static asset path, as you'd do with {% static %}. This makes finding the manifest more agnostic to where on the filesystem it actually is (but it still does need to be locally available to django-vite).

akx avatar Mar 31 '25 12:03 akx

I see your point but letting people use static module for loading the file and the file must be readable will maybe confuse people as they think It may be sored elsewhere ?

MrBin99 avatar May 09 '25 19:05 MrBin99

[...] and the file must be readable will maybe confuse people as they think It may be sored elsewhere ?

You mean possible confusion since django-vite couldn't read the file if it's stored in a non-local storage? I can of course add documentation to that effect.

akx avatar May 12 '25 13:05 akx

Yeah, I don't know if using the static module when for example a user uses AWS S3 is not confusing for them. Because of this, it will not work and they will need to add more code to handle it. Therefore, I think that it's better the other way around that you add code because your configuration is different but not the default and I think adding this will break a lot of peoples code. And just adding documentation is not enougth.

MrBin99 avatar Jul 07 '25 17:07 MrBin99