Ragna.roBrowser
Ragna.roBrowser copied to clipboard
NV_BASIC skill failure should not trigger default animation
Steps to reproduce:
- Create new Novice 1/1
- Type any emote e.g. "/ok"
- Server returns error because your skill level is too low
- Skill.js onSkillResult() it's triggered
Actual result: As every failure in this function it's triggering the default animation. While "Basic skill" it's passive.
Expected result:
should not trigger SkillAction['DEFAULT']
animation.
Additional context Probably there could be more skills like that, but I don't remember easy way to find all the passive skills to compare.
I was thinking about solution like this: https://github.com/MrAntares/roBrowserLegacy/compare/master...kontownik:roBrowserLegacy:fix/basic_skill_failure but I need to hardcode line breaks to match current ones I believe