Tyler Yahn

Results 709 comments of Tyler Yahn

This should be resolved by https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/1593. Please check if this issue still persists with the latest released version and re-open or open a new issue if you still have problems.

> we could group these 3 fields into a "Closing" struct Look into re-designing the closing fields. This may help with testing and could clean things up. _Originally posted by...

This was only partially resolved by #1405. If a global span is already active in the context this will work, as demonstrated in #1405. However, if there is no active...

My initial idea was to update the `noopSpan.TracerProvider` method: https://github.com/open-telemetry/opentelemetry-go/blob/784638358b3d39412703a13fe0bd6aa0908ffe45/trace/noop.go#L84-L85 Similar to https://github.com/open-telemetry/opentelemetry-go/pull/5920 we could call a private method with a `*bool`. For example: ```diff --- a/trace/noop.go +++ b/trace/noop.go @@...

copying the `auto/sdk` to some `go.opentelemetry.io/otel/trace/internal` package would also have the same import cycle issue.

https://github.com/open-telemetry/opentelemetry-go/pull/6203 has merged. We can no instrument that copy of the SDK to support this.

Blocked by either a release of opentelemetry-go or the resolution of https://github.com/open-telemetry/opentelemetry-go-instrumentation/issues/1753. Currently, when trying to test the added probe the comparison of `1.34.1-0.20250205150531-85fab8be9320 > 1.34.0` is returning `false` which...

No, the plan is to always maintain both in both locations. Any changes to the package here need to be PR-ed to `otel`.

The package exported here is used in the global package (https://github.com/open-telemetry/opentelemetry-go/blob/838643a3a52415ca36f7e831e2edcc8c9d489d46/internal/global/trace.go#L152-L176). The one in the trace API is used there to avoid package import cycles. The trace API auto SDK...

After https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/2001 is merged, we need to update dependency on `go.opentelemety.io/otel` to be a released (not commit hash) version. This will also require a release from that package.