Adam Honoré
Adam Honoré
@frenck I fixed the `ruff` and `mypy` errors encountered after you merged the latest `dev` branch into my PR, so it should be fine to review now. I had some...
@frenck, any chance you have time to look at my PR, or can help me find someone else who can? I know you are busy, but it's quite a small...
@frenck pinging you again. It's been almost 5 months, so I hope you will get some time to look at this.
@frenck it looks like several PR's have been opened since I opened mine back in September, trying to solve the same issue: https://github.com/home-assistant/core/pull/129437 https://github.com/home-assistant/core/pull/137771 We should probably figure out which...
> I think this PR looks like the most promising of the three alternatives. > > @MrAdam Could you please add some tests though? Note that we really want tests...
It will probably take some time before I can look at this again (I have started looking into tests), as I just started a new job this week, and am...
@emontnemery I've added some tests, and tried to work with the state machine - I hope you will take a look and see if it's done correctly 👍
I can see that coverage is failing, due to me not having done any negative tests yet - I'll get that fixed soon.
Exporting price as an array is also the case for the following Home Assistant component: https://github.com/custom-components/nordpool