Pimple.js icon indicating copy to clipboard operation
Pimple.js copied to clipboard

V2 Pimple API

Open evillemez opened this issue 10 years ago • 3 comments

Would you be open to changing the API to match v2 of Pimple?

For example, in v2, services are shared by default, so there's no need to call "share". Factory services can be registered via container.factory('name', function(){});. I think there's a few other changes, but not huge ones from what I remember.

evillemez avatar Jun 04 '14 20:06 evillemez

I'll look into that.

Mparaiso avatar Jun 17 '14 15:06 Mparaiso

Working on branch 2.X

Mparaiso avatar Jun 18 '14 14:06 Mparaiso

Cool, let me know if you want some help on anything.

I actually came up with my own version because we needed something really fast for a project, but I didn't bother publishing it: https://github.com/AmericanCouncils/container.js I didn't make a PR on your project because it was so much of a change that it was basically a rewrite.

It's not a direct port of the v2 api, mind you, I was just trying to simplify the api as much as possible. Anyhow, let me know - would rather contribute to one thing.

evillemez avatar Jun 20 '14 14:06 evillemez