mred icon indicating copy to clipboard operation
mred copied to clipboard

Need to NOT recreate the 3D view every time we switch away

Open blairmacintyre opened this issue 6 years ago • 5 comments

I'm in the 3D view, I've position my viewpoint somewhere, I look at a geolocation or image asset, I switch back, and the view is completely reset.

I understand why this is happening: we're recreating the whole panel. This is bad (it was bad as a performance thing, but it's terrible that really hammers the UX)

Need to move the entire 3D canvas into a separate canvas from the one created by React, and then add this canvas to the react canvas.

blairmacintyre avatar May 21 '19 21:05 blairmacintyre

Is this actually urgent? Are you having speed issues? I ask because it may require some deep changes that I'd rather not do while the students are using the tool.

joshmarinacci avatar May 23 '19 04:05 joshmarinacci

It would be less urgent if scene navigation and "recenter" worked properly. But right now, if I look away from the scene and come back, my view is reset, and navigation back to it is hard/impossible.

blairmacintyre avatar May 23 '19 09:05 blairmacintyre

I fixed the view reset. Now it will preserve the orbit control settings

joshmarinacci avatar May 23 '19 21:05 joshmarinacci

Since the view position is being preserved I'm marking this not urgent anymore. I'm keeping it around for the longer term performance issue.

joshmarinacci avatar May 23 '19 22:05 joshmarinacci

Ok.  It will be important soon — as soon as we run this on a desktop that actually supports WebXR, it’s going to try opening WebXR every time … god knows what that will do.


Blair MacIntyre Principle Research Scientist

https://pronoun.is/he/him https://blairmacintyre.me

On May 23, 2019, 6:01 PM -0400, Josh Marinacci [email protected], wrote:

Since the view position is being preserved I'm marking this not urgent anymore. I'm keeping it around for the longer term performance issue. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

blairmacintyre avatar May 23 '19 23:05 blairmacintyre