Moya icon indicating copy to clipboard operation
Moya copied to clipboard

fixed 3 tests not imported needing types

Open IgorRatynski opened this issue 3 years ago • 1 comments

Steps for error reproduction: clone the repo, open Package.swift file, launch tests (by command+u) and after you'll have an error - "Cannot find type 'CGSize' in scope" in "SignalProducer+MoyaSpec", "Single+MoyaSpec" and "Observable+MoyaSpec" files

IgorRatynski avatar Sep 05 '22 00:09 IgorRatynski

Have a similar MR to fix the same things

@AndrewSB Any chance this fix can be merged?

antranapp avatar Sep 23 '22 01:09 antranapp

@IgorRatynski as I commented here, all tests are working fine in the latest version of Xcode. So, in my opinion this PR is not required.

thejohnlima avatar Feb 25 '23 19:02 thejohnlima

hey sorry, just seeing this now. mention me again if this is needed for tests to compile

AndrewSB avatar Feb 25 '23 20:02 AndrewSB