Gary Gozlan

Results 556 comments of Gary Gozlan

@ybiquitous FYI here's a list of the rules that were missing from the OP: - word - `annotation-no-unknown` - `keyframe-block-no-duplicate-selectors` - `keyframe-selector-notation` - [x] `no-irregular-whitespace` - [x] `import-notation` - [x]...

@damianopetrungaro would the commit `"feat(user): Add birthdate"` be the revert of the commit `"feat(user): Remove birthdate"`? Should the type always match the reverted commit's type? Should the message be identical?

Personally I use the `revert` type for commits which _stated_ purpose is to revert. For example if the original commit has some valuable artifacts, I end up with a partial...

@hbetts that doesn't cover my current usage of the revert type which is a partial revert using `git commit`. The **intent** is a revert but granular: https://stackoverflow.com/q/45267653

Most of the time, it's the other way around: you revert the commit *in the spirit* on its initial message but leave out some artifacts that are worth keeping. Don't...

IMHO the short hash of the original commit should be mandatory. Since you allow custom types Ill continue to use the revert type. I was just enquiring as to why...

@damianopetrungaro [this list](https://github.com/conventional-commits/conventionalcommits.org/blame/87d94e3afe74056fac4467f8dd9b76521d17c5a3/content/v1.0.0-beta.2/index.md#L35) should be _'build', 'ci', 'chore', 'docs', 'perf', 'refactor', 'revert', 'style', 'test'_. cf https://github.com/marionebl/commitlint/blob/master/%40commitlint/config-conventional/index.js#L19

I am fine with it but it needs to allow partial reverts as well.

In light of [TCR](https://medium.com/@tdeniffel/tcr-variants-test-commit-revert-bf6bd84b17d3)'s emergence, the revert type may become as essential as fix and feat.