stepmania-server icon indicating copy to clipboard operation
stepmania-server copied to clipboard

Published 20 hours ago • verified publisher icon Moutix

Update protocol

Open nico-abram opened this issue 7 years ago • 4 comments

Update smpackets to this: https://github.com/stepmania/stepmania/pull/1393

nico-abram avatar Jun 12 '17 02:06 nico-abram

Can you add some test for this? Also do we need to check the protocol version?

Moutix avatar Jun 12 '17 09:06 Moutix

I do not know how to add tests. I dont think this breaks backwards compatibility and i think theres no need for versión checks in this(i did this a long time ago so i dont remember very well. Ill test it a bit and get back to you). If and when this and another pr ill be doing to add some tables to the db are merged ill try to pull request the code to actually support matching songs by file hash, and that code does have version checks.

nico-abram avatar Jun 14 '17 02:06 nico-abram

Coverage Status

Coverage increased (+0.03%) to 84.886% when pulling 29700a99dd0f7013c46793bf6752ea0279b9cbb8 on Nickito12:Protocol into d3353ac6f5027d79d443433a7a00c6964d9516b3 on ningirsu:master.

coveralls avatar Jun 16 '17 01:06 coveralls

Coverage Status

Coverage increased (+0.03%) to 84.886% when pulling ba0d80aabb1fc75d18581da28a88267780a5ebec on Nickito12:Protocol into d3353ac6f5027d79d443433a7a00c6964d9516b3 on ningirsu:master.

coveralls avatar Jun 16 '17 01:06 coveralls