stepmania-server icon indicating copy to clipboard operation
stepmania-server copied to clipboard

Fix lobby userlist and roomlist updating

Open nico-abram opened this issue 8 years ago • 3 comments

Fix lobby room and userlist updates

nico-abram avatar Jun 12 '17 02:06 nico-abram

If I didn't send the lobby user list, it's because it's limited to 255 users do we really need to send it?

Moutix avatar Jun 12 '17 09:06 Moutix

I dont think sending the lobby userlist properly is a bad idea. That said i can see it not being a priority. What i do think is a priority is the room list(without it users cant properly recognize/join rooms. Even the state is important in my opinion(a player in a hurry might be looking for a room not in a game). And, if i remember correctly, the lobby userlist and room list are sent in the same packet(therefore not updating the userlist but updating the room list wouldnt make much difference i think)

nico-abram avatar Jun 14 '17 02:06 nico-abram

Coverage Status

Coverage decreased (-0.2%) to 84.68% when pulling 5a249757e001ad0e5ffd4c77b6367c3717cee900 on Nickito12:LobbyUpdates into d3353ac6f5027d79d443433a7a00c6964d9516b3 on ningirsu:master.

coveralls avatar Jun 14 '17 23:06 coveralls