RMINC icon indicating copy to clipboard operation
RMINC copied to clipboard

Arguments did not work

Open anummers opened this issue 4 years ago • 4 comments

https://github.com/Mouse-Imaging-Centre/RMINC/blob/1f2cef9e23b3955bc553a868ad780226e5073f8c/INSTALL#L45

What worked instead was: devtools::install_github("Mouse-Imaging-Centre/RMINC" , build_opts = "--configure-args='--with-build-path='" , upgrade = FALSE)

anummers avatar Jan 15 '21 23:01 anummers

Hi Anum, did you leave --with-build-path blank and that worked?

cfhammill avatar Jan 18 '21 14:01 cfhammill

Hi Chris, I had helped with this, --with-build-path was provided with the path to the install location on that machine. I think the issue here was that the arguments listed in the install docs don't match what we had to provide to devtools::install_github (e.g. build_opts instead of args). Minor issue, and probably related to devtools version?

On Mon, Jan 18, 2021 at 10:00 AM Chris Hammill [email protected] wrote:

Hi Anum, did you leave --with-build-path blank and that worked?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Mouse-Imaging-Centre/RMINC/issues/291#issuecomment-762303127, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNTCJD5TYOC2CNCD6HCGB3S2REHLANCNFSM4WEYYJNQ .

yohanyee avatar Jan 18 '21 19:01 yohanyee

thanks Yohan, that does seem like a devtools change. I'll investigate and fix in the docs

cfhammill avatar Jan 18 '21 21:01 cfhammill

#namedarguments?

gdevenyi avatar Jan 18 '21 23:01 gdevenyi