NotEnoughUpdates icon indicating copy to clipboard operation
NotEnoughUpdates copied to clipboard

Fix detecting if you're in skyblock

Open 0xAda opened this issue 4 years ago • 8 comments

Hypixel is now sometimes sending the server brand as "Hypixel BungeeCord (1.0.0) <- vanilla", this is probably a mistake but this commit makes the regex more lenient so it will detect any string that contains hypixel and looks like bungeecord

0xAda avatar Jan 21 '21 23:01 0xAda

+1 vouch for the REAL fix not done by a non

nerd avatar Jan 22 '21 03:01 nerd

This was made an hour after #134 which also fixes it. This way might be better than that way but you can just request changes

TymanWasTaken avatar Jan 22 '21 15:01 TymanWasTaken

This was made an hour after #134 which also fixes it. This way might be better than that way but you can just request changes

that's not true, you can tell by the number... that PR was made after this one.

nerd avatar Jan 22 '21 15:01 nerd

Wait nvm I can't read

TymanWasTaken avatar Jan 22 '21 15:01 TymanWasTaken

https://github.com/RobotHanzo/NotEnoughUpdates/suites/1887632682/artifacts/36906277 I've built a version based on your PR for those (and myself) that wants to use the fixed mod

RobotHanzo avatar Jan 24 '21 03:01 RobotHanzo

https://github.com/RobotHanzo/NotEnoughUpdates/suites/1887632682/artifacts/36906277 I've built a version based on your PR for those (and myself) that wants to use the fixed mod

You do realize there are fixed versions in the discord

TymanWasTaken avatar Jan 24 '21 03:01 TymanWasTaken

https://github.com/RobotHanzo/NotEnoughUpdates/suites/1887632682/artifacts/36906277 I've built a version based on your PR for those (and myself) that wants to use the fixed mod

You do realize there are fixed versions in the discord

They didn't push it to github

RobotHanzo avatar Jan 24 '21 03:01 RobotHanzo

@Moulberry push it reeeeee

TymanWasTaken avatar Jan 24 '21 03:01 TymanWasTaken