Rob Garrison

Results 770 comments of Rob Garrison

Please make sure you're using `format.es5.js`... if you're using require, try this: ```js var format = require("./node_modules/number-format.js/lib/format.es5"); ```

Hi @rotsee! Oops, yes... the library is only checking the size of the last group. It'll need to be refactored to format the Indian format grouping. Thanks for reporting the...

Hi @sammyhk! Thanks for report!... I've been super busy and forgot to include an enhancement in the release I just published. I'll try to get to it soon-ish. Unless you're...

Hi @jfstephe! I was planning on making this library support an Excel-like format. For example, this would be a `mask` setting: ```js // positive number; negative number; zero mask: "#,###.00_);(#,###.00);...

HI @davidclark87! Hmm, well the number being used is larger than the `Number.MAX_SAFE_INTEGER` value (`9007199254740991`). The internal code would need to be modified to not convert the string into a...

Hi @jfstephe! I was working on rewriting this library, but got distracted by life. I'd be open for a PR... I got stalled on carrying the one to the left...

Hi @maxkan! Hmm, adding this ability to the formatter would make it much more complicated. There are many currency symbols and the mask could also include a longer prefix (e.g....

And I actually thought Excel wrapped negative numbers in parenthesis (e.g. `(12.34) = -$12.34`). Did that change?

Hi @magicaner! This is the expected result when only one symbol is supplied in the mask. In the main readme, [there is a note](https://github.com/Mottie/javascript-number-formatter#note) that better explains this behavior: >...

Wow, I think I need to reword that note... I speaky betta Engrish den dat!