GitHub-userscripts icon indicating copy to clipboard operation
GitHub-userscripts copied to clipboard

Published 20 hours ago • verified publisher icon Mottie

Deals rather badly with cancelled comments

Open xmo-odoo opened this issue 5 years ago • 3 comments

  1. create comment (with [+])
  2. hide all comments in file
  3. show comments
  4. cancel comment created at [1]
  5. hide comments again

Expected: no comment

Observed: a hidden comment mark with 0 next to it, seemingly impossible to get rid of without reloading the page entirely

xmo-odoo avatar Aug 04 '20 06:08 xmo-odoo

Hi @xmo-odoo!

Same here... I didn't get around to troubleshooting & fixing the problem this weekend.

Mottie avatar Aug 09 '20 00:08 Mottie

So when you hide all comments, this userscript is using the built-in setting to hide all comments, so that behavior hasn't changed. I'm not able to duplicate the mentioned problem anymore - maybe I'm missing something?

What I did fix was collapsed comments no longer collapse open editors.

Please let me know if you're still having this issue. If not, please close this issue. If it does still exist, please update the steps to reproduce the problem (if needed) and I'll take a look again soon.

Mottie avatar Sep 30 '20 01:09 Mottie

@Mottie issue doesn't occur anymore, though possibly because the "hidden comments" marker is gone? I think when I tested originally if comments were hidden (actually hidden not collapsed) there would be a gutter icon with the number of hidden comments at that point, and when a comment was cancelled that gutter icon was left with a count of 0.

I should have taken a screenshot, sorry about that.

xmo-odoo avatar Sep 30 '20 09:09 xmo-odoo