mostro icon indicating copy to clipboard operation
mostro copied to clipboard

Upgrade sqlx dependency

Open grunch opened this issue 1 year ago • 9 comments

Upgrade sqlx to latest version

grunch avatar Dec 18 '23 18:12 grunch

hi @grunch as a PR I am trying to update the sqlx version but it depends that sqlx-crud also updates to the latest version of sqlx :sweat_smile:

.. btw I cloned sqlx-crud and after updating the sqlx version and some tweaks on mostro and mostro-core, I was able to update to the latest version of sqlx.

f3r10 avatar Jul 08 '24 16:07 f3r10

wow that's great, I remember that we broke some things after try to update, I don't remember exactly but @arkanoider was working on it, maybe he remember and can send some thoughs about it :D

grunch avatar Jul 08 '24 19:07 grunch

@f3r10 you are a hero doing this. If I can help you ask freely... I think sqlx crud just needs to be updated to latest.sqlx, but rhen we have to work on it and dev never answered! Your commitment is super good!

arkanoider avatar Jul 08 '24 20:07 arkanoider

maybe until the maintainer of sqlx-crud bumps the version of sqlx, it would be possible to create a fork of the project and update the reference of the dependency like so

sqlx-crud = { git = "https://github.com/f3r10/sqlx-crud", features = ["runtime-tokio-rustls"] }

f3r10 avatar Jul 08 '24 22:07 f3r10

Yep! I think he dropped it, we should takeover! Great to have a volunteer...

arkanoider avatar Jul 08 '24 22:07 arkanoider

I think the first step for upgrading sqlx version would be in mostro-core, so I created a pull request about: https://github.com/MostroP2P/mostro-core/pull/57

f3r10 avatar Jul 14 '24 19:07 f3r10

I think the first step for upgrading sqlx version would be in mostro-core, so I created a pull request about: MostroP2P/mostro-core#57

This is the starting point for sure, it's passed some time. Now I think if I remember well that also mostro needs to update sqlx otherwise we will have some errors. Test it please...you need to bump update on Mostro and see if it compiles correctly and work. Before merging this we have to be sure to do not break all, then to maintain it i had started to study the crate, which is a nice derivative macro! Hope you want to try to learn it...one nice thing should be having also blocking calls to CRUD functions for example...

arkanoider avatar Jul 14 '24 22:07 arkanoider

yes, you are right it would also be necessary to bump the version of sqlx and sqlx-crud on Mostro. I have already tested it and Mostro runs correctly.

I have not worked with macros on Rust, but it would be nice to learn it.

f3r10 avatar Jul 19 '24 13:07 f3r10

This issue is free to be taken now

grunch avatar Sep 18 '24 12:09 grunch