txWS icon indicating copy to clipboard operation
txWS copied to clipboard

Allow binary as a 'protocol'

Open mcclymont opened this issue 8 years ago • 3 comments

noVNC has removed support for base64 encoding in the latest release: https://github.com/novnc/noVNC/commit/38781d931ec18304f51ed3469faff8387e3cbc55

This means that noVNC ends up sending the header "Sec-WebSocket-Protocol:binary", and vncAuthProxy/txWS can't deal with that because binary is not in the encoders/decoders dicts and txWS returns false from validateHeaders.

mcclymont avatar Jan 13 '17 11:01 mcclymont

Any chance to merge this?

zgoda avatar Apr 12 '17 14:04 zgoda

The diff looks simple enough to me.

jarrodchesney avatar Apr 12 '17 14:04 jarrodchesney

@MostAwesomeDude pretty please :)

mcclymont avatar May 02 '17 04:05 mcclymont