Oleh Moskovych

Results 21 comments of Oleh Moskovych

@felixfontein , @autrilla , could you please review PR and approve builds? Any additional changes are required? More tests? Functionality is not changed - as you said, output file is...

> @autrilla A test for this would be nice to have Ok, will work on it.

@autrilla , and looks like it's pgp one, which I didn't changed.

I can't proceed with adding new tests as existing are not working properly (see #882)

@tanandy , sorry for delaying, but this PR still require unit test to be covered. I'll try to add them asap.

+1. Even if not sops, just general execution of command, like `exec`/`sh`/etc.

@hiddeco , thanks for pointing me out, but correct me if I'm wrong: to fix the tests: [stores/json/store_test.go](https://github.com/getsops/sops/blob/1ea4a74f658105ddd0b76ff5a33fef55f3eca23b/stores/json/store_test.go) I need to decrypt the file: [stores/json/test_resources/example.json](https://github.com/getsops/sops/blob/1ea4a74f658105ddd0b76ff5a33fef55f3eca23b/stores/json/test_resources/example.json) where it contains aws kms...

@felixfontein , github workflows are not running without any approvals. Can you help with it?

Here what I have: ``` gpg --import pgp/sops_functional_tests_key.asc 2>&1 1>/dev/null || exit 0 gpg: key 3D16CEE4A27381B4: "SOPS Functional Tests Key 1 (https://github.com/mozilla/sops/) " not changed gpg: key 3D16CEE4A27381B4: secret key...