MorsGames
Fix compilation error
Recently, there have been reports of SM64Plus failing to compile as soon as the compiling process starts. The error in question goes something like this: armips.cpp:1414:34: note: 'int64_t' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>'. This PR fixes that.
Are you on Windows or Linux? I'm not having any compilation issues with the latest version of MSYS2.
I mean if it's helping you I don't see a problem adding a simple include statement (assuming it doesn't affect compilation on other platforms, which I'll test) but I thought I'd ask.
Are you on Windows or Linux? I'm not having any compilation issues with the latest version of MSYS2.
I mean if it's helping you I don't see a problem adding a simple include statement (assuming it doesn't affect compilation on other platforms, which I'll test) but I thought I'd ask.
I'm on windows. Fresh install of MSYS2 and everything. It seems to only happen on newer versions of GCC.
Also. This is the same error that these people are getting.
- https://github.com/MorsGames/sm64plus/issues/113
- https://github.com/MorsGames/sm64plus/issues/116
- https://github.com/MorsGames/sm64plus/issues/117
- https://github.com/MorsGames/sm64plus/issues/120
Can at least confirm on the Linux side that this is still an issue, and pulling in OP's branch instead allows it to build just fine.
Can confirm. Building master does not work on EndeavourOS Linux, pulling OP's branch fixes this.
This fixed building on Arch too. Please merge.
Reminder that this comment was made nearly three months ago.
This fixed building on Arch too. Please merge.
Reminder that this comment was made nearly three months ago.
Mors seems to be planning a release for 4.0 with this change already implemented. Not sure when it'll release, but it'll come eventually.
Still happens, still the same fix. It's currently not possible to use SM64 Plus at all without this fix.
