Maurice Faber

Results 293 comments of Maurice Faber

No, like @beansoftapp offered, and what more people are doing, which leads to a lot of (unmaintained) forks: fork your own, or use somebody else's fork (like @beansoftapp's) That is...

That's a nice hack iyam, the best so far ;) Don't forget about it tho: you are then using a hack to use that version, so make sure to always...

Your code is just 33 lines, but I just don't understand why you do this: ``` console.error = (message, error) => global.ErrorUtils.reportError(error); // sending console.error so that it can be...

I refer to that specific line in this report

Already better, but I would say all of `args` needs to be reported, so I would make it: ```js const consoleError = console.error; console.error = (...args) => { global.ErrorUtils.reportError.apply(this, args);...

Actually, I only think console.error should be hijacked in __DEV__, as I now get crashes in production when calling console.error.

Any forward motion towards unifying these efforts? Can #111 not be merged or reworked? Or @IanVS's fork be merged into this one? It sux to have a whole fork for...

yeah, too bad we can't use this plugin without this fix ;(

But how would that work with nested folders? When I generate templates with helmfile these end up in nested file structures.