pr-lint-action icon indicating copy to clipboard operation
pr-lint-action copied to clipboard

Published 20 hours ago • verified publisher icon MorrisonCole

Allow commenting to be turned off

Open MorrisonCole opened this issue 3 years ago • 7 comments

I guess some users will just want the status check and nothing else - it can be annoying to get a tonne of comments!

MorrisonCole avatar Feb 05 '22 00:02 MorrisonCole

I would add that a better solution was to, either:

  • Dont add comments again (it is annoying to have 20 comments stating the same thing)
  • Update the same comment, I prefer this solution honestly, as the same comment can be edited after the action is successful.

Couto avatar Feb 24 '22 12:02 Couto

@Couto yep to be honest didn't give it much thought. I'll have a look at updating the comment / preventing multiple comments when I get around to this!

MorrisonCole avatar Feb 24 '22 13:02 MorrisonCole

I would love any of the above mentioned options! 🔥

gregorybolkenstijn avatar Mar 09 '22 10:03 gregorybolkenstijn

@MorrisonCole Would love to see this! Any updates?

thedmeyer avatar Mar 29 '22 16:03 thedmeyer

@MorrisonCole Any chance this PR could be merged? https://github.com/MorrisonCole/pr-lint-action/pull/286

gregorybolkenstijn avatar May 09 '22 10:05 gregorybolkenstijn

Hey folks - I'm really sorry for having this repo on the backburner for such a long time. I have of course seen all your comments and have set some time aside to address all the open issues this weekend. I'll ping all the threads once the released versions are out!

MorrisonCole avatar Sep 15 '22 20:09 MorrisonCole

v1.7.0 is now released and adds the approach suggested by @Couto of updating the existing comment. Since I'd still like to add the option to turn off comments entirely, I'm leaving this issue open for now, but the annoying multiple-comments problem is at least fixed for now :)

MorrisonCole avatar Sep 17 '22 06:09 MorrisonCole