sync-tab-groups icon indicating copy to clipboard operation
sync-tab-groups copied to clipboard

Active group is not recognized after restart (Chromium)

Open galan opened this issue 5 years ago • 5 comments

Sometimes I have the case that active group is not detected. So when I open up the group selection menu, no group is marked as "Open". All changes I made in the meantime are lost when I switch to a different group.

For sure I could check each time I start the browser if the is marked as active, but this is cumbersome, and I do forget it regularly.

galan avatar Nov 23 '18 08:11 galan

I've reported the same bug with Chromium few months ago: https://github.com/Morikko/sync-tab-groups/issues/141

I really liked STG but since Chromium/Chrome is not a priority for the dev and I've lost many tabs I've switched to a more reliable extension: https://chrome.google.com/webstore/detail/cluster-window-tab-manage/aadahadfdmiibmdhfmpbeeebejmjnkef

Regards :octocat:

mikhoul avatar Nov 23 '18 15:11 mikhoul

I also have this bug on my chrome instance at work. Actually, I have not enough time to work on this right now. Sorry @mikhoul :cry:

I have planned to switch the firefox STG kernel on simple-tab-groups which is more powerful and stable. Thus, I could prune mine to keep only the chromium part and correct those bugs more easily.

Feel free to investigate and propose a PR :)

Morikko avatar Nov 26 '18 22:11 Morikko

Are you able to reproduce with determinism the fact that the group is not recognized ?

I have idea about the reason but real use case will definitely help me fix this.

Also, when it's happened did the tabs in the window have changed ? (Redirection, open, close or move...)

Morikko avatar Jan 02 '19 13:01 Morikko

I think I have pointed out one event, when the group is lost. I have chromium as default browser, when I click on a link to open a new browser, the group is lost (getting a very nice notification now, thanks for that :+1: ). When I open the browser regular, the group is preserved. If the selection of the group depends on the tabs opened by the browser, this seems not to work, since the opened tabs have changed because of the newly opened additional tab.

galan avatar Jan 08 '19 22:01 galan

If the selection of the group depends on the tabs opened by the browser, this seems not to work, since the opened tabs have changed because of the newly opened additional tab.

You got the point and the weakness of the actual method. Actually, doing something precise but still resilient to change is a bit tricky. On FF, I can add an extra id on the window to avoid those dirty tabs comparisons.

I have chromium as default browser, when I click on a link to open a new browser, the group is lost

Thank you for this good test!

getting a very nice notification now, thanks for that

I am glad you enjoy it :)

I will update soon the algorithm to be more resilient!

Morikko avatar Jan 18 '19 00:01 Morikko