sync-tab-groups icon indicating copy to clipboard operation
sync-tab-groups copied to clipboard

Active group is not recognized after session restore

Open jonschz opened this issue 5 years ago • 1 comments

If you have "restore last session on startup" enabled, Sync Tab Groups correctly remembers which group you were in and shows the active group in bold. However, if Firefox cannot recover the last session properly, you get an "emergency session recovery" and you click on "Recover session", Sync Tab groups thinks that you are in a non-synchronized group and shows the old active group as inactive.

I have not been able to test this issue in detail as I don't know how to provoke a session restore, but I think I have seen this problem multiple times and a session restore seems to be the trigger.

I realize that you won't be able to fix this problem any time soon, but I wanted to report it for the record.

jonschz avatar Sep 23 '18 10:09 jonschz

Yes, I think I have already seen the bug.

When Firefox is restarted without exiting properly, it asks you if you want to restore the previous tabs. Unfortunately, the groups binding is done on startup and won't trigger on restore.

Actually, I bypass it by explicitly clicking on the bottom left button in the pop up menu. It will ask FF to create a group from the window. As the window is still bound with a group (firefox side), STG will reattach the window to the right group with the right names. And also actualize all the tabs in the group.

Le dim. 23 sept. 2018 à 12:54, psisquared2 [email protected] a écrit :

If you have "restore last session on startup" enabled, Sync Tab Groups correctly remembers which group you were in and shows the active group in bold. However, if Firefox cannot recover the last session properls, you get an "emergency session recovery" and you click on "Recover session", Sync Tab groups thinks that you are in a non-synchronized group and shows the old active group as inactive.

I have not been able to test this issue in detail as I don't know how to provoke a session restore, but I think I have seen this problem multiple times and a session restore seems to be the trigger.

I realize that you won't be able to fix this problem any time soon, but I wanted to report it for the record.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Morikko/sync-tab-groups/issues/144, or mute the thread https://github.com/notifications/unsubscribe-auth/AHeAFChaleMjTjC4NZYN5Z9aTc1lm00mks5ud2htgaJpZM4W1p2b .

Morikko avatar Sep 27 '18 18:09 Morikko