sync-tab-groups
sync-tab-groups copied to clipboard
Morikko
Chrome extension not reliably highlighting current Tab Group in dialog
Google Chrome 65.0.3325.181 (not latest, one version behind I think).
In the screen shot below, you can see that sync tab groups main dialog doesn't show which window I am currently on. I think this is related to the other issue I described at the end of #80
OK Here's some additional insight. Sometimes, sync tab groups does highlight the tab group in the window correctly, I just noticed this behavior. If I click on another window, and then click back to the "main" window, then tab groups correctly highlights it. However it depends on WHAT TAB I click on, here's an example:
I click on main window to bring it into focus by clicking on one of the tabs in that window. Sync Tab Groups is not highlighting the window name in the dialog.
I click away from that window, and click on the first tab in the main window again to bring it back into focus, now magically, the window name is correctly bolded in the tab groups list dialog.
I can also reproduce this with any window, if I click on the second tab to bring the window into focus, the window is not highlighted. If I then leave the same window in focus and just click on the first tab, then click on the tab groups icon, the window group in the dialog is now highlighted. It seems to be related to clicking on the first tab in each window, on whether tab groups will highlight the window name or not, at least in Google Chrome.
In the screenshot I provided above in my first comment, you can see that the tab that is in focus is not the first tab, it is the last tab, though I don't think it matters which tab is in focus other than the first tab to reliably reproduce.
I also found that even if the first tab is already in focus when you switch to another window, tab groups will not highlight the window group, you have to bring the window into focus, click on the second tab, then click on the first tab again, and then tab groups will highlight the window group in the dialog properly. So again it's related to the first tab in each window being deselected and then reselected.
I can reproduce this reliably.
yes this issue persists, and i cannot use the extension in google chrome at all because it is mixing up windows, not properly highlighting current window, etc.
the extension can't reliably tell which window group I am on, when i switch back and forth between open windows with multiple tabs in each window.
Google Chrome is up to date Version 66.0.3359.170 (Official Build) (64-bit)
There was some promises broken in the latest version for Chrome.... tomorrow the next version will land and will have fixed the promises so try again MAYBE it is the root of the problem especially like me if you use Chrome. 😉
The window focus change was failing, it should be fixed. Could you also check that since #115, the new context is well updated ? (you need to focus the window first and next right click)
Yep, It's working slightly better, but switching between windows, and then clicking the icon, the wrong window group continues to be highlighted.
So if I go to (click on) currently open window (which is window group A) and it has two tabs open, and then I go to window B (which is window group B) and has 4 tabs open, if click back to focus on window A, and then click back to window B, only Window A tab group is highlighted, it seemingly "gets stuck" on Window Group A in tab groups.
Actually, sometimes I notice, when switching from window a to b, it will quickly highlight the correct tab group in the dialog (group b), but then it will update to window group A again! So it will highlight tab group B but then it will jump back to highlight tab group A!!!
If I click on a different tab in window B, then it will update from window group A to B.
The problem is primarily occurring when switching focus back and forth between windows.
Just some precision: V0.7-alpha is not a stable release by definition. It might contained new bugs due to the fact I did a lot of change to add the hiding support. #64 It is available for tests purpose. Be careful with your data.
Else, I will continue to investigate on this problem. Chrome doesn't behave like Firefox...
Le lun. 14 mai 2018 à 17:26, LC [email protected] a écrit :
I am now running 0.7 Alpha in Google Chrome:
[image: si-11-19-27-am_0009] https://user-images.githubusercontent.com/1028272/40006984-b15a6322-5769-11e8-91cf-6d87f2825cad.jpg
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Morikko/sync-tab-groups/issues/110#issuecomment-388858396, or mute the thread https://github.com/notifications/unsubscribe-auth/AHeAFLKBFxQR6qx_PtGp278Aj_xO9wbnks5tyaI9gaJpZM4TjQqi .
I just tested it again with 0.7, the behavior now is interesting, I will make a small video to show you how it behaves now
are you able to reproduce this in chrome on win x64? Google Chrome is up to date Version 67.0.3396.99 (Official Build) (64-bit)
It seems like it's a bit better, but when i switch to the new window and click on the icon, it reverts to the old tab group in the selection bar.