Morganamilo
Update for new alpm version
Update for new alpm version, depends on https://github.com/Morganamilo/aur-depends/pull/19 being in crates.io.
Also deleted and added Cargo.lock to .gitignore as then it can resolve crates dependency tree on initial cargo build.
Solves #1454
Bro rebase, and why you deleted the lock file
Bro I don't have keys setup on this machine for the signing yet, needed to get this done, and there are no branches or merges I added, just basic commits as that is what github web interface allows for.
As for deleting lock file, saves regenerating it every time something is updated, there isn't one in the aur-depends repo, there is no need for it to be in the repo really (which can't be properly updated until crates.io is updated with new aur-depends anyway).
As for your other comment, did you read the description? I could go and pull in modified aur-depends into this repository instead but why when I can make a pull request there for it.
As for deleting lock file, saves regenerating it every time something is updated, there isn't one in the aur-depends repo,
The default advice for Cargo.lock is to commit it. The traditional guideline is "check it in for a binary, don't for a library. aur-depends doesn't because it is a library. paru is a binary, so it's checked in.
Anyway it has nothing to do with fixing this issue, so it doesn't belong in this PR.
As for deleting lock file, saves regenerating it every time something is updated, there isn't one in the aur-depends repo,
The default advice for
Cargo.lockis to commit it. The traditional guideline is "check it in for a binary, don't for a library.aur-dependsdoesn't because it is a library.paruis a binary, so it's checked in.Anyway it has nothing to do with fixing this issue, so it doesn't belong in this PR.
Well, it needs updating, I can not do that with the dynamic linking until aur-depends is updated on cargo. I'm more than willing to swap out those commits for one with updated Cargo.lock when I can. Locally I just path included updated aur-depends.
Basically the advice due to the way the building and what is statically and what is dynamically linked is done, is a bit of a catch22 here.
This is just like https://github.com/Morganamilo/paru/pull/1456 . It doesn't work, since aur-depends=5.0.0 isn't a real version
As michaelbeaumont said, removing Cargo.lock goes outside the scope of such a PR and there is a good reason why it's included by default https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control
All I'm saying is that if you really want to remove Cargo.lock and believe you have a valid argument, then you should do that in a separate PR, not attach it as part of something meant to address something entirely different
This is just like #1456 . It doesn't work, since aur-depends=5.0.0 isn't a real version
As michaelbeaumont said, removing Cargo.lock goes outside the scope of such a PR and there is a good reason why it's included by default https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control
All I'm saying is that if you really want to remove Cargo.lock and believe you have a valid argument, then you should do that in a separate PR, not attach it as part of something meant to address something entirely different
Please read the description!!! There is a link!!! We can't do anything until aur-depends is updated, I have a PR there too. And that is where Cargo.lock is a problem.
removing a lock file is chaotic IMO
I have already said it will change, when the hard dependency pull request is done so it can be handled.
From what I gathered, this PR is supposed to be a draft PR, but you did not mark it like that, and you dislike it when others treat it as a non-draft?
This is just like #1456 . It doesn't work, since aur-depends=5.0.0 isn't a real version As michaelbeaumont said, removing Cargo.lock goes outside the scope of such a PR and there is a good reason why it's included by default https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control All I'm saying is that if you really want to remove Cargo.lock and believe you have a valid argument, then you should do that in a separate PR, not attach it as part of something meant to address something entirely different
Please read the description!!! There is a link!!! We can't do anything until aur-depends is updated, I have a PR there too. And that is where Cargo.lock is a problem.
I'm sorry for misinterpreting your intentions if what you say is true. That being said, the description really makes it sound like you're intentionally removing the Cargo.logk file.
I suggest you mark this PR as a draft to make it clear it's not meant to be merged as-is.
aur-dependsdoesn't have 5.0.0, so you can't update lockfile, it's true.- Rebase! Discard your changes in
.gitignore, and leave Cargo.lock alone untilaur-dependshas a new release, then docargo update alpm alpm-utilsandgit add . && git commit --amend
Bro I don't have keys setup on this machine for the signing yet
Fine I'll do this for you