core icon indicating copy to clipboard operation
core copied to clipboard

NeoForge port

Open Lolothepro opened this issue 1 year ago • 9 comments

Is your feature request related to a problem? Please describe. I want to use this mod with NeoForge

Describe the solution you'd like That I can use it

Which Minecraft versions would this feature apply to? 1.20.4

Lolothepro avatar Feb 21 '24 20:02 Lolothepro

It looks like the reason MoreMcmeta isn't loading in NeoForge is because of the Forge version number:

[15:50:59] [main/ERROR]: Missing language javafml version [47,) wanted by gui-plugin-forge-1.20.1-1.0.1-forge.jar, found 2.0
[15:50:59] [main/ERROR]: Missing language javafml version [47,) wanted by properties-parser-plugin-forge-1.20.1-1.1.5-forge.jar, found 2.0
[15:50:59] [main/ERROR]: Missing language javafml version [49,) wanted by emissive-plugin-1.20.4-2.0.4-forge.jar, found 2.0
[15:50:59] [main/ERROR]: Missing language javafml version [49,) wanted by moremcmeta-1.20.4-4.4.7-forge.jar, found 2.0
[15:50:59] [main/ERROR]: Missing language javafml version [47,) wanted by texture-plugin-forge-1.20.1-1.0.1-forge.jar, found 2.0
[15:50:59] [main/ERROR]: Missing language javafml version [47,) wanted by animation-plugin-forge-1.20.1-1.0.3-forge.jar, found 2.0
[15:50:59] [main/ERROR]: Missing language javafml version [47,) wanted by json-parser-plugin-forge-1.20.1-1.1.1-forge.jar, found 2.0

I may be able to remove the Forge version requirement for newer MC versions to get it to load with NeoForge.

It's a lot of work for me to support a new mod loader, mainly from a testing perspective. If that were to happen, support for older MC versions would need to be dropped. The reason there has been no official decision on what to do about NeoForge is that I've been waiting to gauge how much of the community moves over. Hopefully, the short-term fix is simple, and I can figure something out over the long term as NeoForge and Forge most likely diverge.

soir20 avatar Mar 02 '24 21:03 soir20

Unfortunately, the simple solution doesn't look like it's going to work. I think the best solution is to drop active support for 1.16-1.18, and possibly 1.19.4, and then create a Neoforge port. These versions are significantly less popular than 1.19.2, 1.20.1, 1.20.2, and 1.20.4 based on download counts. MoreMcmeta also hasn't needed to update much recently, so the current versions should be pretty stable even if they aren't updated anymore.

I will write up a more complete post once I've decided for sure what versions won't be in active support anymore and what dropping "active support" means.

Since this is an issue with MoreMcmeta core as well, I'll transfer this over to that repository.

soir20 avatar Mar 16 '24 21:03 soir20

I've noticed quite a few mods moving to Neo Forge exclusively now, so I'm hoping this does end up getting a port for it.

deftesthawk avatar Sep 27 '24 18:09 deftesthawk

Any update on this ?

Lolothepro avatar Jan 05 '25 14:01 Lolothepro

It's the second-highest priority issue besides some crashes on 4.5.1. Otherwise, I don't have updates on this yet

soir20 avatar Jan 07 '25 02:01 soir20

at this point forge has been dead. the old devs left. i say drop lexforge support for 1.21.1+ early. nobody uses those versions of lexforge anyways.

OrdinaryCloverOC avatar Jan 16 '25 00:01 OrdinaryCloverOC

  1. Maintenance isn't the only problem here. There's still work required to actually do the port.
  2. MoreMcmeta is, statistically, downloaded more on the original Forge than on Fabric.

soir20 avatar Jan 16 '25 01:01 soir20

  1. Maintenance isn't the only problem here. There's still work required to actually do the port.

  2. MoreMcmeta is, statistically, downloaded more on the original Forge than on Fabric.

  1. fair
  2. on 1.21.1 you get barely a thousand downloads per release for forge on both sites combined. i'm not talking about pre-1.21.1, which doesn't have neoforge popularity. (also sorry for necro-ing, it's just been bugging me)

OrdinaryCloverOC avatar Mar 25 '25 04:03 OrdinaryCloverOC

It's not that I just don't want to support NeoForge or that I'm somehow rejecting doing a port. I simply haven't had time to do this large of a task on top of my job and other realities of life. If someone wants to submit a PR to do the port, I'd happily review it.

soir20 avatar Mar 25 '25 04:03 soir20