issue-tracker icon indicating copy to clipboard operation
issue-tracker copied to clipboard

Published 20 hours ago • verified publisher icon MoralisWeb3

Non-Transferable not working for ERC-721 NFT Collection Module

Open brother-ran opened this issue 2 years ago • 2 comments

NFT tokens are still transferable by everyone even after we set contract to non-transferable successfully.

brother-ran avatar Mar 30 '22 05:03 brother-ran

Contract: https://mumbai.polygonscan.com/address/0x702436c48C7a83D9e81261758bAbDB8fB9f3c429

Transaction to set non-transferable (via Dashboard): https://mumbai.polygonscan.com/tx/0x43500fb47963be11c691862993bc54beb5061b0bb0362bcab2383cbbf590774a

Successful transfer: https://mumbai.polygonscan.com/tx/0x8fe33ab0e1af238137724c6b5a61ddd992f6634cd69c29e5df8580730a5b10c7

brother-ran avatar Mar 30 '22 06:03 brother-ran

Dig a little in to the contract code. Looks like it requires TRANSFER_ROLE to be revoked from the zero address to restrict the transfer. However, dashboard UI does not have the entrance to do that. It seems to me a bug of the new dashboard UI.

We manually interact with the contract to revoked the role and now it is correctly restricting the transfer. https://mumbai.polygonscan.com/tx/0xfbc5a87d13ea13bccc461700e3c01511047eda2645c2847d2bc538d593fb5519 https://mumbai.polygonscan.com/tx/0xf993fc64272036604f11f921f9b0270f7a1ceed2eb7180ef9a76c905eea54339

brother-ran avatar Mar 30 '22 08:03 brother-ran