FastCrud icon indicating copy to clipboard operation
FastCrud copied to clipboard

Added support for SAP / Sybase Anyhwere SQL dialect

Open madf0x opened this issue 3 years ago • 3 comments

I fixed the named parameter issues by adding the possibilty to add a parameter suffix (in SAnywhere SQL its ?paramName?) and made the suffix default to empty string.

The sybase anywhere implementation is very close to MS SQL, so I only made a few necessary changes. I tested it in a customer project and so far it seems to work fine.

madf0x avatar Apr 11 '22 11:04 madf0x

Wow, thank you so much! I'll do some research to understand what it takes to add it to our test suite.

MoonStorm avatar Apr 12 '22 19:04 MoonStorm

You're welcome, thank you for actively maintaining this dapper extension. I'll have to look into dapper to fix it there too.

madf0x avatar Apr 12 '22 19:04 madf0x

Just noticed I got a little mixed up with my git accounts, don't worry, all the code came from the same person :)

ev1ls33d avatar Jul 04 '22 15:07 ev1ls33d

Discovered a lot of problems with the code after attaching tests to it so you might wanna check the changes we've made to your code for 3.1.

MoonStorm avatar Mar 10 '23 17:03 MoonStorm

thanks for the feedback, I will look into your changes.

ev1ls33d avatar Mar 10 '23 18:03 ev1ls33d