learning-react icon indicating copy to clipboard operation
learning-react copied to clipboard

Chap 8: Incorporating React Markdown

Open khanhtran94 opened this issue 2 years ago • 0 comments

I think you not pass param login from UserRepositories to RepoMenu component Readme not render because login undefined

import Fetch from "./Fetch";
import RepoMenu from "./RepoMenu";

export default function UserRepositories({
  login,
  selectedRepo,
  onSelect = f => f
}) {
  return (
    <Fetch
      uri={`https://api.github.com/users/${login}/repos`}
      renderSuccess={({ data }) => (
        <RepoMenu
          login={login}
          repositories={data}
          selectedRepo={selectedRepo}
          onSelect={onSelect}
        />
      )}
    />
  );
}

In RepositoryReadme, useEffect check !login, loadReadme will never run

 useEffect(() => {
    if (!repo || !login) {
      return;
    }
    loadReadme(login, repo).catch(setError);

  }, [repo]);

khanhtran94 avatar May 08 '22 09:05 khanhtran94