TombEngine icon indicating copy to clipboard operation
TombEngine copied to clipboard

Camera when getting out of water gets to Lara's side

Open Joey79100 opened this issue 1 year ago • 0 comments

In TR5, when Lara gets out of water, the camera snapped.

In TEN, lines 276 and 277 have been added, which are the only differences compared to lara_as_controlled_no_look(): image


However, when not using the original animation, I get the issue as shown in this video: the camera slightly rotates as Lara's hips rotate. With the original animation this is probably not visible, because her hips don't rotate. https://github.com/MontyTRC89/TombEngine/assets/12445716/291c98f8-d6e3-49d7-afef-4b85893b2658 As you can see after: when pulling up from a ledge, which uses lara_as_controlled_no_look(), the issue isn't there.

After a little bit of investigation, it seems the comment in that bit of code above is wrong: it's not line 277 (the node) that fixes the snapping, but line 276 (the flag): When I remove line 277, it fixes the camera: https://github.com/MontyTRC89/TombEngine/assets/12445716/874b6f98-5b00-44eb-bdb9-81194a361559 (and on the other hand, if I remove 276 but leave 277, I get the rotation and the snapping)

May we remove that line?

Mind that I have not tested with the official TEN animation, but I doubt the result will be much different.

Joey79100 avatar Jan 05 '24 21:01 Joey79100