TombEngine icon indicating copy to clipboard operation
TombEngine copied to clipboard

New animation sound conditions

Open Sezzary opened this issue 1 year ago • 2 comments

Revises animation sound effect conditions. Will require asset updates for water creatures later, but for now their sounds are handled with a special exception.

Old sound conditions:

  • Always
  • Land
  • Water

New sound conditions:

  • Always
  • DryLand
  • WetLand
  • Swamp
  • Underwater

To test:

  • Underwater sounds should only play when the camera is submerged.
  • Swamp sounds shoudl play only in swamps.
  • WetLand sounds should play in shallow water as before. Check on sloped surfaces.

Sezzary avatar Dec 11 '23 02:12 Sezzary

I propose to leave Land as Land, and rename WetLand to ShallowWater.

Lwmte avatar Dec 17 '23 08:12 Lwmte

I've tried to test it but I'm getting compiling errors.

In Jeep there is DryLand, so now it should be "Land"?

In animation.cpp line case AnimCommandType::Flipeffect:, the compiler says the initialization of frameNumber is omitted in this case. Maybe a version conflict affected this PR somehow?

Adngel avatar Dec 30 '23 10:12 Adngel