Tomb-Editor icon indicating copy to clipboard operation
Tomb-Editor copied to clipboard

ST: It is not possible to change sound info slot id

Open Castigavi opened this issue 4 years ago • 3 comments

Summary: While adding a new sound info you are asked to provide a slot ID. After that though you are not able to change the ID anymore. You have to actually click on the "Add new sound info" button and create a new slot. You can select and highlight the numbers in the ID field, but you are not able to edit them.

This limitation seems redundant. I don't really see the reason why users shouldn't be allowed to do that? Infact, I have internally raged over this limitation once, because I was comparing sounds between Sound Tool (for xml) and Notepad++ (for Samples.txt) and have by mistake put all my sounds in wrong slots (ST starts numbers with 0, notepad++ starts first line with 1 lmao). A simple mistake, but I have already configured all the slots and fixing that through ST meant removing all of that and starting from scratch. I had to manually reassign IDs by editing xml file in notepad++.

Repro steps:

  1. Launch ST and click on Add new sound slot info. Pick any slot id.
  2. Select that slot and try to change its ID number. Notice it is not possible to do that.

Expected results: User should be able to change number within ID field.

obraz

Castigavi avatar Jun 01 '20 21:06 Castigavi

Not a bug, but limitation of sound tool, sorry :(

Lwmte avatar Jun 02 '20 14:06 Lwmte

Ok on second thought it is maybe fixable. But tell me what is expected results in these cases:

  1. There is existing sound info with same ID
  2. What should ST do with existing sound ID in old slot if slot ID is changed

If you come up with decent UI choice to resolve both situations, maybe it can be done.

Lwmte avatar Jun 02 '20 15:06 Lwmte

Answering to your questions:

  1. There is existing sound info with same ID
  • In this case the Sound Tool should just inform the user, maybe in a pop-up window, that the sound ID is already occupied by another sound info in the currently opened file and that it should be removed first. Then ST should just revert the change like as if user never made it.
  1. What should ST do with existing sound ID in old slot if slot ID is changed
  • I'm not sure if I understand the question well, but I think that in this case the old ID should be just removed. The user changed it exactly because he wanted the existing sound info to use different ID. In case when user wanted to use an old ID later he can just create a new sound info with the old ID.

Castigavi avatar Jun 02 '20 18:06 Castigavi