OdysseyDecomp icon indicating copy to clipboard operation
OdysseyDecomp copied to clipboard

Custom linter: Enforce `NON_MATCHING` comment above non-matching functions

Open MonsterDruide1 opened this issue 1 year ago • 5 comments

Requires reading the CSV to see which functions should (not) match, then the linter should complain if either matching functions are marked as NON_MATCHING or non-matching functions lack the comment.

MonsterDruide1 avatar Jun 06 '24 09:06 MonsterDruide1

Hmm, while we're at it, can we also enforce decomp.me links being listed above all those functions?

MonsterDruide1 avatar Feb 21 '25 14:02 MonsterDruide1

Sure. I’ve also been implemented a thing into the same check that disallows non inline functions that aren’t found in the csv

LynxDev2 avatar Feb 21 '25 15:02 LynxDev2

It’s gonna take some time for me to make a decomp.me for all those functions though 😅

LynxDev2 avatar Feb 21 '25 15:02 LynxDev2

How many mismatching non-library functions do we have?

MonsterDruide1 avatar Feb 21 '25 15:02 MonsterDruide1

There are currently 33 NON_MATCHING comments in the repo of which 5 already have a decomp.me link

LynxDev2 avatar Feb 21 '25 16:02 LynxDev2