OdysseyDecomp
OdysseyDecomp copied to clipboard
lots of AreaObj.* functions
pasted PR comment from the other repo:
This covers
- Reversed
AreaObjDirector's methods and fixed some errors in its header AreaObjFactoryheader + reversed both methods- Headers for
AreaObjMtxConnecterandAreaObjMtxConnecterHolder - 2 inlined functions in
Factoryto get AreaObj + AreaObjDirector stuff matching - Headers for area objects used in the factory (includes
TrafficArea,CameraStartParam,SeBarrierArea,SePlayArea,ViewCtrlArea,BirdGatheringSpotArea,ExtForceArea,ForceRecoveryKidsArea,MoveArea2D,NpcForceMaterialCodeArea,RouteGuideArea, andStainArea) ProjectAreaFactoryheader and a non-matching constructor
Things to sanity check:
AreaObjDirector::getAreaObjGroupdid not match when using the inlined_getAreaObjGroup. Instead, it only matches when I paste the exact same code into the public method. Inlining the binary search was necessary for several functions to match, but having 2 identical functions feels wrong.- I don't know if I defined
BirdGatheringSpotArea::AreaClippingInfoin the right spot
I'll deal with the linting stuff later I'm going to bed
Alright, I'll review when the linter is (mostly) fixed.
lib/al/src/Library/Area/AreaObjGroup.cpp line 40 at r2 (raw file):
Previously, MonsterDruide1 wrote…
Uhh, are you sure about this?
we've been over this one before https://github.com/odyssey-modding/odyssey/pull/19#discussion_r1310355086