OdysseyDecomp icon indicating copy to clipboard operation
OdysseyDecomp copied to clipboard

lots of AreaObj.* functions

Open whaleymar opened this issue 1 year ago • 3 comments

pasted PR comment from the other repo:

This covers

  • Reversed AreaObjDirector's methods and fixed some errors in its header
  • AreaObjFactory header + reversed both methods
  • Headers for AreaObjMtxConnecter and AreaObjMtxConnecterHolder
  • 2 inlined functions in Factory to get AreaObj + AreaObjDirector stuff matching
  • Headers for area objects used in the factory (includes TrafficArea, CameraStartParam, SeBarrierArea, SePlayArea, ViewCtrlArea, BirdGatheringSpotArea, ExtForceArea, ForceRecoveryKidsArea, MoveArea2D, NpcForceMaterialCodeArea, RouteGuideArea, and StainArea)
  • ProjectAreaFactory header and a non-matching constructor

Things to sanity check:

  • AreaObjDirector::getAreaObjGroup did not match when using the inlined _getAreaObjGroup. Instead, it only matches when I paste the exact same code into the public method. Inlining the binary search was necessary for several functions to match, but having 2 identical functions feels wrong.
  • I don't know if I defined BirdGatheringSpotArea::AreaClippingInfo in the right spot

This change is Reviewable

whaleymar avatar Mar 08 '24 04:03 whaleymar

I'll deal with the linting stuff later I'm going to bed

whaleymar avatar Mar 08 '24 04:03 whaleymar

Alright, I'll review when the linter is (mostly) fixed.

MonsterDruide1 avatar Mar 08 '24 13:03 MonsterDruide1

lib/al/src/Library/Area/AreaObjGroup.cpp line 40 at r2 (raw file):

Previously, MonsterDruide1 wrote…

Uhh, are you sure about this?

we've been over this one before https://github.com/odyssey-modding/odyssey/pull/19#discussion_r1310355086

whaleymar avatar Mar 09 '24 03:03 whaleymar