MonitorControl icon indicating copy to clipboard operation
MonitorControl copied to clipboard

Ability to enable fine scale OSD even with a built-in display only

Open Volodymyr-13 opened this issue 2 years ago • 16 comments

Before opening the issue, have you...?

  • [X] Searched for existing issues

Is your feature request related to a problem? Please describe

On my MacBook Pro M1 2021, when I change brightness using system F1/F2 keys it changes brightness to -+ 6% or something aka one bar step:

nativeUI

So each this bar changes -+ steps too much for me, I'd like to have an option to change -+ 1% using F1/F2 keys

Describe the solution you'd like

Add option to set value of % in which each F1/F2 key press will change value of brightness.

Describe alternatives you've considered

In my NativeDisplayBrightness app there is such option, it changes brightness more precise, so just by adding less then -+6% for each step. Screen Shot

Anything else?

No response

Volodymyr-13 avatar Apr 09 '22 17:04 Volodymyr-13

Hi @KAMIKAZEUA The option you're looking for is called "Use fine OSD Scale" located here in the app settings pref_3

the0neyouseek avatar Apr 09 '22 19:04 the0neyouseek

Hey @the0neyouseek this option didn't worked for me. Using MacBook Pro M1 2021.

https://user-images.githubusercontent.com/3391456/162590269-2ecae7d5-0315-4a94-b598-8d29c2c6fc70.mov

Volodymyr-13 avatar Apr 09 '22 20:04 Volodymyr-13

Hey @KAMIKAZEUA - are you using an external display or only the built-in display?

waydabber avatar Apr 09 '22 20:04 waydabber

Only built in at the moment, just I'm not in office(where I have external monitor). Also pressing Shift+Option changes smoothly.

Volodymyr-13 avatar Apr 09 '22 20:04 Volodymyr-13

All right. The problem probably is that MonitorControl disengages from the keyboard completely when only the internal display is connected. This is intentional and is a feature actually (there were some requests towards this, I don't recall why exactly though). This might be finetuned in a way that this does not happen when the fine OSD scale is enabled.

waydabber avatar Apr 09 '22 20:04 waydabber

I think this was the reason:

https://github.com/MonitorControl/MonitorControl/issues/456

waydabber avatar Apr 09 '22 20:04 waydabber

I see, but that was an OLD macOS. A lot was changed since that time. It's now working well, since it detects built-in display correctly:

Screen Shot

Hmm, look what I found, if you just uncheck/check Brightness it will start to change smoothly:

https://user-images.githubusercontent.com/3391456/162591584-aee10f71-f7cf-4ccf-b83f-f67b35c41867.mov

Even if I restart app, it will continue to work. But if I disable OSD scale option and then quit app - it will not work after next start of the app, if I enable OSD scale again. But I can do this trick again then, just uncheck/check Brightness)

Bug = feature).

Volodymyr-13 avatar Apr 09 '22 21:04 Volodymyr-13

And yet, it still changes mostly for 2% per step.. but I'd like to have 1% per step max.. :p

Volodymyr-13 avatar Apr 09 '22 21:04 Volodymyr-13

Hmm. Something is off there obviously. I can convert this into a feature request.

waydabber avatar Apr 10 '22 06:04 waydabber

@waydabber also, while using OSD scale for built-in display, I noted one thing: if auto-brightness enabled, it changes brightness obviously, after that if I press F1/F2 - screen will blinks in brightness level. So, it's not reading current value of display brightness, before apply changes to it.

Volodymyr-13 avatar Apr 11 '22 09:04 Volodymyr-13

Hi @KAMIKAZEUA - yes, if the system changes the brightness, it does not inform MonitorControl about it. MC however polls the system brightness periodically and if it detects a change, it will alter the slider and update its knowledge about the brightness level + tries to poll faster for a while. You'll see this - if you change the brightness using the ambint light sensor (for example by covering it with your hands), you'll see your screen dim and the MC brightness slider follow it after a while.

If you however try to change the brightness using MC before MC updated its internal understanding of current brightness, the screen will flash.

waydabber avatar Apr 11 '22 10:04 waydabber

Hey @waydabber Just used this over almost all day at work. In 80% of cases it blinks brightness on F1/F2 key, which is really annoying. I'm sitting near window and looks like brightness is changing a lot, clouds are moving so it's really dynamic.

I think this should be like maybe another bug report, since MC should read system brightness when I press F1/F2 key. But since I'm currently using like bug=feature, this is perhaps should be considered and tested while implementing current request. If this is possible of course.

Volodymyr-13 avatar Apr 11 '22 14:04 Volodymyr-13

Indeed, just tested this, it is actually a different problem - it flashes even when MC has updated the slider and reacted to the change in brightness level. I'll look into it.

waydabber avatar Apr 11 '22 14:04 waydabber

But yes, you should create a separate bug report about this one. :) Thank you!

waydabber avatar Apr 11 '22 14:04 waydabber

I just not sure if I have to include this OSD scale option enabled with this flashing bug. Since I found this already: https://github.com/MonitorControl/MonitorControl/issues/931 so this if this will be fixed, then we good :)

Volodymyr-13 avatar Apr 11 '22 14:04 Volodymyr-13

Yes, you are right, I added a note to that bug about the fact that the problem is deeper than known. Honestly I use my macbook in clamshell mode mostly plus I have the ambient light sensor disabled so I did not notice the issue. Sorry about that + thank you!

waydabber avatar Apr 11 '22 15:04 waydabber

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 11 '23 21:04 stale[bot]