mongoengine icon indicating copy to clipboard operation
mongoengine copied to clipboard

Docker/compose for local development

Open juannyG opened this issue 4 years ago • 1 comments

Hi there! Long time mongoengine user, first time (potential) contributor here.

I started poking around the tickets regarding transaction support and thought I might take a crack at that. When I forked & cloned, I didn't see any docker configurations for local development.

Would there be any interest in that as an option for local development? Here's something I quickly whipped up in my fork that has passing tests, in case anyone is curious as to what the footprint of this addition might be: https://github.com/MongoEngine/mongoengine/compare/master...juannyG:local-docker

juannyG avatar Aug 13 '21 17:08 juannyG

Hi @juannyG, I actually do also have a docker-compose that I use locally but that I keep out of git (untracked), I'm in favor of adding a docker-compose but I'd only keep mongo in there (with replicaset configured with 1 instance, as required for transaction). This will be required to run the tests for transactions locally anyway.

Thus I'd avoid a dockerfile for mongoengine itself (and add it to docker-compose), I believe this adds an extra layer of complexity for contributing/debugging and creating a venv is pretty straightforward.

If you are ok with that, feel free to add it

bagerard avatar Aug 23 '21 20:08 bagerard