mongoengine icon indicating copy to clipboard operation
mongoengine copied to clipboard

modifying test about connection

Open Davidrjx opened this issue 7 years ago • 4 comments

new test package called connections and move related modules in; new related test methods;

Davidrjx avatar Oct 04 '17 14:10 Davidrjx

do someone as an assignee make the review for this request?

Davidrjx avatar Nov 07 '17 02:11 Davidrjx

Hi @Davidrjx ! Could you summarize these changes in the PR's description? Just a few brief sentences what it gives us, why it's useful, whether it's backward compatible, what was the problem with the previous structure, etc.

Ping me please when that's done and I'll review.

wojcikstefan avatar Nov 07 '17 14:11 wojcikstefan

@wojcikstefan thanks for your reply. The pull request mainly contains: (1) for replicaset and readpreference option in mongodb, do some adjustments in mongoengine connection module to make connection setting more suitable for Pymongo client. previous possible problems: a bit unclear/incorrect connection setting arguments processing in kwargs/uri_opt. (2) at the same time, combined with modifications above, also i do the same thing for connection test, which involves test module location tuning and methods new addition. previous possible problems: uncomfortable module archive and incomplete tests. (3) above tests are run with Py2(2.7),Py3(3.4) and Pymongo2(2.9&2.8),Pymongo3(3.3)

Davidrjx avatar Nov 08 '17 06:11 Davidrjx

@wojcikstefan please review

Davidrjx avatar Nov 21 '17 01:11 Davidrjx