terraform-provider-kafka icon indicating copy to clipboard operation
terraform-provider-kafka copied to clipboard

Published 20 hours ago • verified publisher icon Mongey

Add support for oauthbearer as the sasl mechanism

Open kmdlcp opened this issue 1 year ago • 5 comments

Oauthbearer is one of the sasl mechanisms supported by Kafka. It would be great if you also supported this.

kmdlcp avatar Feb 01 '24 15:02 kmdlcp

If i make a pull request that supports this, will you be willing to approve it rather quickly? Assuming that you don't find problems with the PR?

kmdlcp avatar Feb 02 '24 13:02 kmdlcp

If i make a pull request that supports this, will you be willing to approve it rather quickly? Assuming that you don't find problems with the PR?

If there's sufficient tests around it, yep

Mongey avatar Feb 02 '24 14:02 Mongey

I made the PR:

https://github.com/Mongey/terraform-provider-kafka/pull/379

kmdlcp avatar Feb 07 '24 13:02 kmdlcp

https://github.com/Mongey/terraform-provider-kafka/pull/384

update code to allow specifying aws profile

Spragalas avatar Feb 13 '24 12:02 Spragalas

#384

update code to allow specifying aws profile

These are separate issues! This issue calls for generic OAuth support. Which i implemented in #379 The Aws is a specific OAuth, that should be handeled seperately.

kmdlcp avatar Feb 14 '24 16:02 kmdlcp

Closing this issue as it has been complete with the merge of PR #379

kmdlcp avatar Mar 14 '24 11:03 kmdlcp