Alexander Potapov

Results 35 comments of Alexander Potapov

Mostly fine. but I not really like that sky on sponza gives the halo, also the halo is too strong for fires You can move forward with other PR. I...

Hi, thanks for PR! Have not start in-depth review process yet, but lets do couple of things to simplify the process and speed-up the merge 1) I see there is...

Hi, sorry for delaying the review! Can you explain why you used `intensity` in CameraSSR? Its not a physical term. I suppose metalness of surface should be used instead?

I made a glass bricks (remove roughness texture, roughness=0, metallness=1). When I set "receieve SSR" I got degradation from 5ms to 20ms. Thats not acceptable performance. It should behave normal...

these artefacts under objects also need to be fixed. There should be a depth check ![image](https://github.com/asc-community/MxEngine/assets/40578274/806683f6-8093-414c-a01b-5e89d7bd969c)

> ![image](https://private-user-images.githubusercontent.com/53587145/316616306-704dba8c-2ef3-4d5a-b1c4-051136e45d0b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTE2NTM4NDIsIm5iZiI6MTcxMTY1MzU0MiwicGF0aCI6Ii81MzU4NzE0NS8zMTY2MTYzMDYtNzA0ZGJhOGMtMmVmMy00ZDVhLWIxYzQtMDUxMTM2ZTQ1ZDBiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzI4VDE5MTkwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUwMWZiMTMzMTdlY2Y3MDQxOGFlNzJkMWYxYTg3YTIyNzM1YjZkYTA1ZDUxZjc0MDFjMTQ3Mjg5MGRiYmFkM2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.7BucVxKYbypcuDBXfdKScFchKcEysaXVPopEve0miUA) Cost is way less than 1ms under level=2. Higher level also can produce less noisy result. This method can be the base to do further advanced optimizations like...

Do not have time to support such variety of compilers. If you managed to build it with MINGW, feel free to create a PR with build fixes

add 'unsigned long' overload for GUI Editor - https://github.com/asc-community/MxEngine/commit/46da9f3c7437264910f849a04204d72c059912cc. Original issue with ambiguity should be fixed. Still have no plans to add Apple support

having similar issue with some letters Font: https://www.fontsquirrel.com/fonts/open-sans "OpenSans-Regular.ttf" Command: `msdfgen.exe -font OpenSans-Regular.ttf 'M' -size 32 32 -testrender test.png 128 128` Output: ![output](https://github.com/Chlumsky/msdfgen/assets/40578274/a4d2bfbe-d83c-496a-ad67-c4f5119fd749) Render: ![test](https://github.com/Chlumsky/msdfgen/assets/40578274/e99d93f8-d182-440a-b786-d797e59a22ff)

Should be possible with #11 a custom pass can be created that will somehow transfer depth image to color image (simular to ImGuiRenderPass)