react-oauth icon indicating copy to clipboard operation
react-oauth copied to clipboard

about nonOAuthError

Open ya3ya6 opened this issue 11 months ago • 1 comments

Hey. i created a google console project, i tested in one local project, it worked fine. i then moved to my another project, it didn't work there. but there wasn't any error, or success, or ... it's not clearly stated that there is a nonOAuthError. developer will get alot confused (hopeless), becase nothing will happen (popup opens, account is selected, then nothing will happen, no error, no success.). so i think:

  • you should merge those errors
  • Or you should do a console.error on that case
  • Or making it so clear that there is another error handler
  • ... After moving the package out of nodemodules and changing the code to log it , It still says message: "popup closed". at lease now it's a bit clear that it's from the google part. so i think this situation is alittle pain for developer, so you better to handle it different. (that callback is kind of unclear / hidden now. maybe it's better to be part of onError. and console.error it if it's not possible.)

ya3ya6 avatar Mar 25 '24 11:03 ya3ya6