Molkobain

Results 214 comments of Molkobain

Sorry @piRGoif I just saw that comments from the last review where not submitted :/

Pending after functional team review : "Datamodel changes are never simple, @etaloc will discuss it with you next week (you have a meeting)"

Put on "Pending Combodo update" as Erwan / Thomas discussion led to "wait for iTop 3.1 linkedset refactoring discussions"

Technical review: * @Molkobain will discuss with Alexandre / Vincent about possible consequences throughout the app. * @Molkobain will create a modernization ticket to use the AttributeDefinition::GetValidationPattern() globally in the...

> Technical review: > > * @Molkobain will discuss with Alexandre / Vincent about possible consequences throughout the app. > * @Molkobain will create a modernization ticket to use the...

@Hipska do you mind if we rename the PR "Improve AttributeDecimal validation during CSV import" as the main impact of it is not the RegExp change but the change in...

Accepted in functional review. Planned for 3.2: * Introduces a behavior change in the CSV import as it will be blocking (hence not in 3.0.x) * Along with the fix...

Thanks Thomas. Merge will be done when internal ticket will be processed.

@eespie will: - Create the corresponding bug in the bug tracker. - Discuss with @Rorcha07 about it - Study debug / verbose output when several CRON instances are running, which...

Hello @Hipska , Pierre is off for the next 2 weeks. Regarding your question, there is no unit test on this yet, but I'm sure your alreaday knew that 😁...