cookiecutter-cms icon indicating copy to clipboard operation
cookiecutter-cms copied to clipboard

PEP 621

Open eirrgang opened this issue 2 years ago • 2 comments

Move the metadata and as much setuptools configuration as possible to pyproject.toml.

This reduces reliance on setup.cfg, and maximally generalizes the build system configuration as supported by setuptools 61.0.

TODO:

  • update cookiecutter version
  • update documentation

Per discussion at #149, it seems appropriate to wait at least a few months before finalizing and considering this PR.

eirrgang avatar Jul 29 '22 19:07 eirrgang

This pull request fixes 2 alerts when merging 800f4926e65f1883a996f344ac5eced7f2723e96 into 51c8757345851d032d40a29dac64df0b2f83b66d - view on LGTM.com

fixed alerts:

  • 1 for Except block handles 'BaseException'
  • 1 for Suspicious unused loop iteration variable

lgtm-com[bot] avatar Jul 29 '22 19:07 lgtm-com[bot]

Codecov Report

Merging #152 (f08c2f3) into master (3288929) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   44.44%   44.44%           
=======================================
  Files          12        8    -4     
  Lines          54       36   -18     
=======================================
- Hits           24       16    -8     
+ Misses         30       20   -10     
Flag Coverage Δ
unittests 44.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
prj_1_2_2/prj_1_2_2/prj_1_2_2.py
prj_1_1_1/prj_1_1_1/prj_1_1_1.py
prj_1_2_2/prj_1_2_2/__init__.py
prj_1_1_1/prj_1_1_1/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 29 '22 19:07 codecov[bot]

I am going to make another pass to make sure I got all of the updates. (update: I i think we're good now)

Also, note (@Lnaden ) that we want to check the classifiers.

eirrgang avatar Aug 12 '22 13:08 eirrgang

This pull request fixes 2 alerts when merging 4d0f29c870ddb51f13eba3f2830bc1d7bf65a1d8 into 51c8757345851d032d40a29dac64df0b2f83b66d - view on LGTM.com

fixed alerts:

  • 1 for Except block handles 'BaseException'
  • 1 for Suspicious unused loop iteration variable

lgtm-com[bot] avatar Aug 12 '22 14:08 lgtm-com[bot]

To make editing easier, I am going to merge this, then fix the dependency conflicts. I think there is a problem with the python we are invoking in GHA and the Python which is installed with the dependencies during the psuedo-validation. Since I have to manually edit that file anyways, I'm going to handle it in a separate PR. I'm going to bump up to 3.8 and go from there.

Lnaden avatar Aug 18 '22 18:08 Lnaden