QCFractal icon indicating copy to clipboard operation
QCFractal copied to clipboard

Changes to set default driver for running properites computation

Open ahurta92 opened this issue 5 years ago • 2 comments

Description

The purpose of the PR is to be able to set a Dataset's default driver to something other than the default "energy". I was hoping to compute dipole moments with nwchem on my Dataset. In order to do so, I need to use the "properties" driver. These changes allow me to do that. It also allows get_values to return energy values when the driver is "properties". As a note, I wasn't able to set the default driver using ds.data.default_driver="properties" because the Datamodel class is immutable.

Changelog description

Creates set_default_driver() function to be able to set the default driver on Dataset collections.

Status

  • [ ] Code base linted
  • [ ] Ready to go

ahurta92 avatar Jan 28 '20 16:01 ahurta92

This pull request introduces 1 alert and fixes 2 when merging 88be061f2f3936fbb5d4940f5ba432684ab566d1 into a1691bfa8c852b40f8c9283b33ae9882d76065ba - view on LGTM.com

new alerts:

  • 1 for Syntax error

fixed alerts:

  • 1 for Except block handles 'BaseException'
  • 1 for Mismatch between signature and use of an overridden method

lgtm-com[bot] avatar Jan 28 '20 16:01 lgtm-com[bot]

Yes, please!

dgasmith avatar Jan 30 '20 20:01 dgasmith

Datasets have radically changed in v0.50, and most defaults are no longer settable in a singlepoint dataset. I would be happy to talk and go over the new interface if you would like!

bennybp avatar Sep 14 '23 15:09 bennybp