QCFractal icon indicating copy to clipboard operation
QCFractal copied to clipboard

add thread and ternary plots

Open loriab opened this issue 6 years ago • 4 comments

Description

DON'T MERGE as this is only rewrites of matplotlib routines that function on data. Presently no integration with QCA.

Todos

  • [x] plotly threads plot
  • [x] plotly ternary plot
  • [ ] plotly threads plot of qcf data
  • [ ] plotly ternary plot of qcf data
  • [ ] find a decent RGB colormap in plotly -- their "Jet" is very dark so that red/blue are hard to distinguish
Screen Shot 2019-10-14 at 11 09 36 AM Screen Shot 2019-10-14 at 11 08 52 AM

Questions

  • [ ] Using the plotly built-in ternary would be nice, but I don't see plotting two at once or turning one upside down. If anyone sees a better path, let me know.

Status

  • [ ] Changelog updated
  • [ ] Ready to go

loriab avatar Oct 14 '19 15:10 loriab

This pull request introduces 3 alerts when merging 7f5a94b59c5e6a73ffba6a3eec0a40575b4b6c3d into 7f5585d446276db10f4b5cbb0ba8e8c24192da93 - view on LGTM.com

new alerts:

  • 3 for Unused local variable

lgtm-com[bot] avatar Oct 14 '19 15:10 lgtm-com[bot]

Cool! This looks great.

I agree that we need to hand code the ternaries from Plotly basics rather than their built in function.

You may want to turn off the grid lines, like so..

dgasmith avatar Oct 14 '19 18:10 dgasmith

turn off the blue bkgd + white grid lines for both ternary and threads or just the former?

loriab avatar Oct 14 '19 20:10 loriab

For ternary for sure. For the threads you may want to consider shifting the chart +/- 0.5 to have the grid correctly line up, may with a view.

dgasmith avatar Oct 15 '19 13:10 dgasmith