QCElemental icon indicating copy to clipboard operation
QCElemental copied to clipboard

rejigger errors

Open loriab opened this issue 6 years ago • 1 comments

The psi4-originated parts of qcel raised ValidationErrors in general. But that's pydantic's pet error, too, so the former got backed away to ValueErrors. But maybe not enough, hence https://github.com/MolSSI/QCElemental/pull/42#issue-259146291 . Go through and unify error handling (w/o forgetting the docstrings) so that we're not catching generic Exceptions.

loriab avatar Mar 07 '19 15:03 loriab

@loriab The code base currently catches Exception in five places (quickly search code for except Exception to find them). Has this issue been adequately addressed? Or would you like to address these last five cases as well?

coltonbh avatar Mar 29 '23 05:03 coltonbh