python_scripting_cms

python_scripting_cms copied to clipboard

Introduce `elif` concept

2

Hi, thank you for the tutorial. I just have a suggestion on the use of `elif` clause instead of just `if` clause in this block: https://github.com/MolSSI-Education/python_scripting_cms/edit/gh-pages/_episodes/02-file_parsing.md#L256-L268 ```python ... for line...

khoivan88

1. Use context-manager to open and read file. 2. Add `break` for breaking out of the loop while reading a file to no wasting computer resources.

khoivan88

Hi, I would like to suggest the use of context-manager (`with` statement) for the open, read and write file, specifically for this [03-multiple_files.md](https://github.com/MolSSI-Education/python_scripting_cms/pull/53/files#diff-e40f9e8cf14e764cdf233ef93464ff60) Khoi Van

khoivan88

khoivan88

In line 30, numpy.float() is deprecated and the error text suggested using base float(), which seems to work fine. Please delete this line and the text below before submitting your...

BrandyRussell