brigadier icon indicating copy to clipboard operation
brigadier copied to clipboard

Add missing `fail`s to end of `try` blocks in tests

Open bbb651 opened this issue 1 year ago • 1 comments

I'm working on changes to read{Int,Long,Float,Double} to make them less greedy and noitced some tests that should've failed.

I went through every try catch and verified try properly fails.

bbb651 avatar Nov 08 '24 00:11 bbb651

I finished implementing my primitive parsing rework, making a PR is blocked on this. Is it ok to remove isAllowedNumber? There are at least a few usages of it, mainly in minecraft mods, I think it's quite unfortunate it was public in the first place (on that note, should isAsciiDigit be private?)

By the way, I noticed readBoolean uses readString() rather than readUnquotedString() directly, making it parse "true" and "false" in addition to true and false. Is this intended? It's untested and undocumented.

bbb651 avatar Nov 08 '24 02:11 bbb651